Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat #1112

Closed
wants to merge 3 commits into from
Closed

Reformat #1112

wants to merge 3 commits into from

Conversation

yaxu
Copy link
Member

@yaxu yaxu commented Jan 22, 2025

My editor reformatted these files on the patterned-tactus branch without me realising. I could try to untangle my changes and undo the reformat, but thought I'd reformat them separately on this PR, and then merge back into patterned-tactus, to hopefully end up with a clean PR for that.

@yaxu yaxu marked this pull request as ready for review January 22, 2025 23:01
@yaxu
Copy link
Member Author

yaxu commented Jan 23, 2025

Looking into it, this is formatted with ormolu, which has clear goals stated here:
https://github.com/tweag/ormolu

It seems to be purposefully non-configurable to create some kind of standard way of formatting.

Previously I've used stylish:
https://github.com/haskell/stylish-haskell

Without doing a close comparison, is seems to be more "light touch".

There is also fourmolu, which is a fork of ormolu that is more configurable. It's called fourmolu from its (default?) four-character indent.
https://github.com/fourmolu/fourmolu

These are all actively maintained, and fourmolu merges upstream changes from ormolu.

I have no strong feelings on code formatting rules, so would be happy to go with a opinionated option like ormolu as I don't have strong opinions of my own. :) What do others think?

I think we should try to merge as many PRs as possible before applying the formatting to all files.

Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment out of the blue (I'm still lurking all the PRs :) )
I like this formatting style a lot 🚀

v)
$ cycleArcsInArc a

-- | In each of @a <*> b@, @a <* b@ and @a *> b@
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ormolu seems to have deleted this documentation completely??

@yaxu yaxu closed this Jan 27, 2025
@yaxu yaxu deleted the reformat branch January 27, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants