Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload artifact #1120

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Fix upload artifact #1120

merged 4 commits into from
Jan 24, 2025

Conversation

yaxu
Copy link
Member

@yaxu yaxu commented Jan 24, 2025

Not yet fixed..

@yaxu
Copy link
Member Author

yaxu commented Jan 24, 2025

I upgraded some actions but still it's not working, failing here with a path error:
https://github.com/tidalcycles/Tidal/actions/runs/12951179422/job/36125648358?pr=1120

I guess something moved with the new action versions. @polymorphicengine I don't suppose you have any time to look at it?

Otherwise we can take it out of the actions for now.

@sss-create
Copy link
Collaborator

I tackled this a few day ago and traced the .ghcup folder on my machine (linux). The first path error is quite easy to resolve but ‚moving installed package files‘ was unsolvable in my attempt.

@polymorphicengine
Copy link
Collaborator

i think we should remove the builds, i'm pretty sure even if the build would succeed, the binaries would be broken.. it is still the same linking issue that was introduced by tidal-link and seems to be incompatible with how hint works, here is a reference:
haskell-hint/hint#156

i have to say that at this point i lost the hope of a distributable release of tidal..

@yaxu
Copy link
Member Author

yaxu commented Jan 24, 2025

i have to say that at this point i lost the hope of a distributable release of tidal..

A shame given all the work you put into it, but it does seem to be a never-ending nightmare.. Having the haskell interpreter working in the web browser is on the ghc roadmap, at least.

@yaxu
Copy link
Member Author

yaxu commented Jan 24, 2025

Ok I've disabled the workflows in github. Will merge this anyway, if only to test we get a green build finally..

@yaxu yaxu merged commit 94e3e5c into dev Jan 24, 2025
40 of 46 checks passed
@yaxu yaxu deleted the fix-upload-artifact branch January 24, 2025 19:41
@Zalastax
Copy link
Collaborator

Was there ever any bug report to GHC to request/discuss adding the missing relocation implementation to GHC's custom linker? Would it be worthwhile to create?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants