Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary solution regarding dimRed #232

Merged
merged 1 commit into from
Jan 12, 2025
Merged

temporary solution regarding dimRed #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/CRAN-R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ jobs:
extra-packages: any::rcmdcheck
needs: check

- name: Install dimRed versions
run: |
# Temp due to dimRed removal from CRAN
try(pak::pkg_install("gdkrmr/dimRed"))
shell: Rscript {0}

- uses: r-lib/actions/check-r-package@v2

- name: Notify slack fail
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/GH-R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,8 @@ jobs:
"tidymodels/poissonreg",
"tidymodels/rules"
)))
try(pak::pkg_install(c(
"tidymodels/dials",
"tidymodels/hardhat",
"tidymodels/modeldata",
"tidymodels/rsample",
"tidymodels/spatialsample",
"tidymodels/yardstick"
)))
Comment on lines -85 to -92
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional? :)

# Temp due to dimRed removal from CRAN
try(pak::pkg_install("gdkrmr/dimRed"))
shell: Rscript {0}

- uses: r-lib/actions/check-r-package@v2
Expand Down
4 changes: 2 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ Authors@R: c(
Description: A place for units tests that depend on multiple packages.
License: MIT + file LICENSE
Depends:
tidymodels
tidymodels,
pak
Suggests:
aorsf,
baguette,
Expand All @@ -21,7 +22,6 @@ Suggests:
conflicted,
coin,
dials,
dimRed,
discrim,
doParallel,
dplyr,
Expand Down
1 change: 1 addition & 0 deletions extratests.Rproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Version: 1.0
ProjectId: 37f7ffa9-f646-46cc-bcc2-5afbe8d7ca41

RestoreWorkspace: No
SaveWorkspace: No
Expand Down
Loading