changes from reviewer feedback

tidymodels · Sep 25, 2024 · e51463e · e51463e
1 parent cd5a32b
commit e51463e
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 120 deletions.
diff --git a/tests/testthat/_snaps/augment.md b/tests/testthat/_snaps/augment.md
@@ -10,30 +10,3 @@
     Message
       Quantile levels: 0.2, 0.4, 0.6, 0.8, and 1.
 
----
-
-    Code
-      linear_reg() %>% set_mode("quantile regression", quantile_levels = c(probs_1,
-        probs_1))
-    Condition
-      Error in `set_mode()`:
-      ! Quantile levels should be unique.
-      i The following values were repeated: 0.2, 0.4, 0.6, 0.8, and 1.
-
----
-
-    Code
-      linear_reg() %>% set_mode("quantile regression", quantile_levels = c(probs_1,
-        NA))
-    Condition
-      Error in `set_mode()`:
-      ! `quantile_levels` must be a number, not a numeric `NA`.
-
----
-
-    Code
-      linear_reg() %>% set_mode("quantile regression")
-    Condition
-      Error in `set_mode()`:
-      ! `quantile_levels` cannot be "NULL".
-
diff --git a/tests/testthat/_snaps/quantile-reg-specs.md b/tests/testthat/_snaps/quantile-reg-specs.md
diff --git a/tests/testthat/test-augment.R b/tests/testthat/test-augment.R
@@ -98,19 +98,4 @@ test_that('quantile regression models', {
   expect_snapshot(
     linear_reg() %>% set_mode("quantile regression", quantile_levels = probs_1)
   )
-
-  expect_snapshot(
-    linear_reg() %>% set_mode("quantile regression", quantile_levels = c(probs_1, probs_1)),
-    error = TRUE
-  )
-
-  expect_snapshot(
-    linear_reg() %>% set_mode("quantile regression", quantile_levels = c(probs_1, NA)),
-    error = TRUE
-  )
-
-  expect_snapshot(
-    linear_reg() %>% set_mode("quantile regression"),
-    error = TRUE
-  )
 })
diff --git a/tests/testthat/test-linear_reg_quantreg.R b/tests/testthat/test-linear_reg_quantreg.R
@@ -2,8 +2,6 @@ test_that('linear quantile regression via quantreg - single quantile', {
   skip_if_not_installed("quantreg")
   skip_if_not_installed("hardhat", minimum_version = "1.4.0.9002")
 
-  library(hardhat)
-
   # data in `helper-objects.R`
 
   one_quant <-

diff --git a/tests/testthat/test-quantile-reg-specs.R b/tests/testthat/test-quantile-reg-specs.R