Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export check_args() for developers of custom models #1057

Closed
mattheaphy opened this issue Jan 19, 2024 · 3 comments · Fixed by #1059
Closed

Export check_args() for developers of custom models #1057

mattheaphy opened this issue Jan 19, 2024 · 3 comments · Fixed by #1059
Labels
feature a feature request or enhancement

Comments

@mattheaphy
Copy link

Feature

check_args() is an internal generic function that is used by parsnip models to validate that parameters have reasonable values before a model is fit.

For developers of custom parsnip models, it would be nice if this function was exported so that appropriate S3 methods could be written to validate parameters on any new models.

@simonpcouch
Copy link
Contributor

I agree with you! Will look into this.

In the spirit of https://github.com/tidymodels/parsnip/issues/826.🐛

@simonpcouch simonpcouch added the feature a feature request or enhancement label Jan 22, 2024
@mattheaphy
Copy link
Author

Thank you!

Copy link

github-actions bot commented Feb 7, 2024

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants