Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export check_args() #1059

Merged
merged 1 commit into from
Jan 23, 2024
Merged

export check_args() #1059

merged 1 commit into from
Jan 23, 2024

Conversation

simonpcouch
Copy link
Contributor

Closes #1057.

@simonpcouch simonpcouch requested a review from hfrick January 22, 2024 21:42
hfrick
hfrick approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with exporting this. It'll only help for new models but not new engines but that's reason enough for me 👍

@simonpcouch simonpcouch merged commit bf3f505 into main Jan 23, 2024
7 checks passed
@simonpcouch simonpcouch deleted the check_args-1057 branch January 23, 2024 14:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hfrick hfrick hfrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export check_args() for developers of custom models
2 participants
@simonpcouch @hfrick