deprecate rpart_train()
#1048
Merged
deprecate rpart_train()
#1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
commented
Jan 16, 2024
| @@ -165,6 +168,12 @@ check_args.decision_tree <- function(object) { | |||
| #' @export | |||
| rpart_train <- | |||
| function(formula, data, weights = NULL, cp = 0.01, minsplit = 20, maxdepth = 30, ...) { | |||
| lifecycle::deprecate_warn( | |||
There was a problem hiding this comment.
Starting with a more aggressive deprecation as, from what I can tell, rpart_train() was never used, even when it was first committed.
| @@ -1,5 +1,7 @@ | |||
| # parsnip (development version) | |||
|
|
|||
| * `rpart_train()` has been deprecated in favor of using `decision_tree()` with the `"rpart"` engine or `rpart::rpart()` directly (#1044). | |||
There was a problem hiding this comment.
Some of these bullets have the parens before the periods, others not. We can fix before release.☃️
There was a problem hiding this comment.
The style guide says to put them before the period 👍
There was a problem hiding this comment.
I'm so opposed to that part of the style guide 😄
topepo
approved these changes
Jan 23, 2024
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1044.🌲🚃
My main question here is whether we should port some of this argument documentation to the
details_decision_tree_rparthelp-file. Much of these docs seem relevant torpart_train()rather than rpart in general.