Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for #1039 #1066

Merged
merged 2 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# parsnip (development version)

* We no longer add `eval_time` arguments to the prediction specification for the engine (#1039).

* parsnip now lets the engines for [mlp()] check for acceptable values of the activation function (#1019)

* Tightened logic for outcome checking. This resolves issues—some errors and some silent failures—when atomic outcome variables have an attribute (#1060, #1061).
Expand Down
1 change: 0 additions & 1 deletion R/predict_hazard.R
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ predict_hazard.model_fit <- function(object,
new_data <- object$spec$method$pred$hazard$pre(new_data, object)

# Pass some extra arguments to be used in post-processor
topepo marked this conversation as resolved.
Show resolved Hide resolved
topepo marked this conversation as resolved.
Show resolved Hide resolved
object$spec$method$pred$hazard$args$eval_time <- eval_time
pred_call <- make_pred_call(object$spec$method$pred$hazard)

res <- eval_tidy(pred_call)
Expand Down
1 change: 0 additions & 1 deletion R/predict_survival.R
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ predict_survival.model_fit <- function(object,
new_data <- object$spec$method$pred$survival$pre(new_data, object)

# Pass some extra arguments to be used in post-processor
topepo marked this conversation as resolved.
Show resolved Hide resolved
topepo marked this conversation as resolved.
Show resolved Hide resolved
object$spec$method$pred$survival$args$eval_time <- eval_time
pred_call <- make_pred_call(object$spec$method$pred$survival)

res <- eval_tidy(pred_call)
Expand Down
Loading