mass replace of rlang::abort with cli::cli_abort #1152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
reviewed
Aug 16, 2024
There was a problem hiding this comment.
While transitioning directly from rlang::abort() to cli::cli_abort() with a Find and Replace doesn't introduce new issues, we tend to also revisit the message formatting using inline markup when we do so. Would you be interested in revising this PR to remove calls to glue::glue() and format these messages with inline markup?
|
I'm going to go ahead and close. Thank you for the PR! If you'd like to pick this back up, please feel free to holler here and we'll reopen. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mass replace of rlang::abort with cli::cli_abort, no user input or special glue::glue brackets were used, so a mass replace was made #1142