Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document sparse data usage in parsnip #1171

Merged
merged 4 commits into from
Sep 9, 2024
Merged

document sparse data usage in parsnip #1171

merged 4 commits into from
Sep 9, 2024

Conversation

EmilHvitfeldt
Copy link
Member

Ref: #1125

Tried to follow how we documented case weights usage across models/engines.

?sparse_data doesn't really say a lot, but it also doesn't really need to because parsnip should just work if the engine allows it

R/sparsevctrs.R Outdated Show resolved Hide resolved
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, this is a nice addition.

Note to self that I ought to make sure passing sparse data works in bonsai with LightGBM. Let me know if you have any notes to keep in mind there.

R/sparsevctrs.R Outdated Show resolved Hide resolved
R/sparsevctrs.R Outdated Show resolved Hide resolved
@EmilHvitfeldt EmilHvitfeldt merged commit cee2bb8 into main Sep 9, 2024
10 checks passed
@EmilHvitfeldt EmilHvitfeldt deleted the doc-sparse-data branch September 9, 2024 19:26
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants