expect_error(regexp = NA) -> expect_no_condition()
#1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
commented
Sep 9, 2024
| regexp = NA | ||
| ) | ||
| expect_no_error(expect_no_warning( | ||
| set_dependency("bart", "dbarts", "dbarts") |
There was a problem hiding this comment.
There's a <dplyr_regroup> condition with no message here; it's not visible at all as a user, so just opted to ignore it.
EmilHvitfeldt
approved these changes
Sep 9, 2024
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1096 but does not close—these are just the cases where
regexp = NA, i.e. we're testing that there's no error. For all but one case, we can actually test the more stricter version, that there is no condition.