update checks and snapshots

R/corr.R

@@ -129,6 +129,12 @@ step_corr_new <-
 prep.step_corr <- function(x, training, info = NULL, ...) {
   col_names <- recipes_eval_select(x$terms, training, info)
   check_type(training[, col_names], types = c("double", "integer"))
+  check_number_decimal(x$threshold, min = 0, max = 1, arg = "threshold")
+  use <- x$use
+  rlang::arg_match(use, c("all.obs", "complete.obs", "pairwise.complete.obs",
+                            "everything", "na.or.complete"))
+  method <- x$method
+  rlang::arg_match(method, c("pearson", "kendall", "spearman"))
 
   wts <- get_case_weights(info, training)
   were_weights_used <- are_weights_used(wts, unsupervised = TRUE)

tests/testthat/_snaps/corr.md

@@ -128,3 +128,31 @@
       -- Operations 
       * Correlation filter on: V6 and V1 | Trained
 
+# bad args
+
+    Code
+      recipe(mpg ~ ., mtcars) %>% step_corr(all_predictors(), threshold = 2) %>% prep()
+    Condition
+      Error in `step_corr()`:
+      Caused by error in `prep()`:
+      ! `threshold` must be a number between 0 and 1, not the number 2.
+
+---
+
+    Code
+      recipe(mpg ~ ., mtcars) %>% step_corr(all_predictors(), use = "this") %>% prep()
+    Condition
+      Error in `step_corr()`:
+      Caused by error in `prep()`:
+      ! `use` must be one of "all.obs", "complete.obs", "pairwise.complete.obs", "everything", or "na.or.complete", not "this".
+
+---
+
+    Code
+      recipe(mpg ~ ., mtcars) %>% step_corr(all_predictors(), method = "my dissertation") %>%
+        prep()
+    Condition
+      Error in `step_corr()`:
+      Caused by error in `prep()`:
+      ! `method` must be one of "pearson", "kendall", or "spearman", not "my dissertation".
+

tests/testthat/test-corr.R

@@ -207,3 +207,25 @@ test_that("tunable is setup to work with extract_parameter_set_dials", {
   expect_s3_class(params, "parameters")
   expect_identical(nrow(params), 1L)
 })
+
+test_that("bad args", {
+  expect_snapshot(
+    recipe(mpg ~ ., mtcars) %>%
+      step_corr(all_predictors(), threshold = 2) %>%
+      prep(),
+    error = TRUE
+  )
+  expect_snapshot(
+    recipe(mpg ~ ., mtcars) %>%
+      step_corr(all_predictors(), use = "this") %>%
+      prep(),
+    error = TRUE
+  )
+  expect_snapshot(
+    recipe(mpg ~ ., mtcars) %>%
+      step_corr(all_predictors(), method = "my dissertation") %>%
+      prep(),
+    error = TRUE
+  )
+})
+