Use cli::cli_abort() in all steps #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
approved these changes
Nov 17, 2023
| @@ -4,23 +4,23 @@ | |||
| iris_rec %>% step_sample(size = -1) | |||
| Condition | |||
| Error in `step_sample()`: | |||
| ! `size` should be a positive number or NULL. | |||
| ! `size` must be a number larger than or equal to 0 or `NULL`, not the number -1. | |||
There was a problem hiding this comment.
Suggested change
| ! `size` must be a number larger than or equal to 0 or `NULL`, not the number -1. | |
| ! `size` must be `NULL` or a number larger than or equal to 0, not the number -1. |
with the current wording, i initially thought NULL completed some part of the clause "a number larger than or equal to 0"
There was a problem hiding this comment.
This is handled by check_number_decimal() so I'm hesitant to change it
tests/testthat/_snaps/window.md
Outdated
| @@ -89,7 +89,7 @@ | |||
| Condition | |||
| Error in `step_window()`: | |||
| Caused by error in `prep()`: | |||
| ! There were 2 term(s) selected but 1 values for the new features were passed to `names`. | |||
| ! There were 2 terms selected but 1 values for the new features were passed to `names`. | |||
There was a problem hiding this comment.
Suggested change
| ! There were 2 terms selected but 1 values for the new features were passed to `names`. | |
| ! There were 2 terms selected but 1 value for the new features was passed to `names`. |
pluralization is currently correct for the plural case, though :)
Co-authored-by: Simon P. Couch <[email protected]>
Co-authored-by: Simon P. Couch <[email protected]>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1237
With this PR, we now have converted all
alert()tocli_abort()🎉