Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declense verb in abort by 'offenders' quantity #1400

Merged
merged 2 commits into from
Nov 26, 2024
Merged

declense verb in abort by 'offenders' quantity #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6258b5
declense verb in abort by 'offenders' quantity
corybrunson Nov 25, 2024
d14ee24
update snapshot
EmilHvitfeldt Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions R/selections.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
#' functions aren't restricted to predictors. They will thus select outcomes,
#' ID, and predictor columns alike. This is why these functions should be used
#' with care, and why [tidyselect::everything()] likely isn't what you need.
#'
#'
#' For example:
#'
#' \preformatted{
Expand Down Expand Up @@ -204,8 +204,8 @@ recipes_eval_select <- function(quos, data, info, ..., allow_rename = FALSE,
offenders <- offenders[offenders != ""]

cli::cli_abort(
"The following argument{?s} {?was/were} specified but do not exist: \\
{.arg {offenders}}.",
"The following argument{?s} {?was/were} specified but do{?es/} not exist: \\
{.arg {offenders}}.",
call = call
)
}
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/basics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@
Condition
Error in `step_pca()`:
Caused by error in `prep()`:
! The following argument was specified but do not exist: `number`.
! The following argument was specified but does not exist: `number`.

---

Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/rm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Condition
Error in `step_rm()`:
Caused by error in `prep()`:
! The following argument was specified but do not exist: `sepal_length`.
! The following argument was specified but does not exist: `sepal_length`.

# empty printing

Expand Down
Loading