Merge pull request #113 from tidymodels/updates

Updates
tidymodels · Jan 17, 2023 · 52b0f2d · 52b0f2d
2 parents 58351b7 + b3c95c1
commit 52b0f2d
Show file tree

Hide file tree

Showing 6 changed files with 65 additions and 62 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: tidypredict
 Title: Run Predictions Inside the Database
-Version: 0.4.9.9001
+Version: 0.5
 Authors@R:
     c(
       person("Edgar", "Ruiz", email = "[email protected]", role = c("aut", "cre")),
@@ -24,7 +24,6 @@ Imports:
     knitr,
     purrr,
     rlang,
-    stringr,
     tibble,
     tidyr
 Suggests:

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,13 @@
 # tidypredict (development version)
 
+- Changes maintainer to Edgar Ruiz
+
+- Updates author's email addresses.
+
+- Removes dependency with `stringr`
+
+- Fixes issue with `earth` parsed_models (#108)
+
 - Addresses issues with XGBoost models
 
 - Improvements to XGBoosts tests

diff --git a/R/model-earth.R b/R/model-earth.R
@@ -62,11 +62,16 @@ mars_terms <- function(mod, is_glm) {
     tidyr::pivot_longer(cols = c(-column),
                         values_to = "value",
                         names_to = "term") %>% 
-    dplyr::mutate(level = 
-                    case_when(
-                      value == 1 ~ stringr::str_remove(term, paste0("^", column)),
-                      TRUE ~ NA_character_)
-    ) %>% 
+    purrr::transpose() %>% 
+    purrr::map(~ {
+      if(.x$value == 1) {
+        .x$level <- gsub(.x$column, "", .x$term)  
+      } else {
+        .x$level <- NA
+      }
+      .x
+    }) %>% 
+    dplyr::bind_rows() %>% 
     dplyr::filter(value == 1) %>% 
     dplyr::select(-value)
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,15 +1,39 @@
 ## Release summary
 
-* Switches to the Max Kuhn as package maintainer
+- Addresses CRAN Package Test Results issues
+
+- Changes maintainer to Edgar Ruiz
+
+- Updates author's email addresses.
+
+- Removes dependency with `stringr`
+
+- Fixes issue with `earth` parsed_models (#108)
+
+- Addresses issues with XGBoost models
+
+- Improvements to XGBoosts tests
 
 ## Comments
 
 * Having Max as the maintainer will guarantee good follow through for any communications with CRAN.  This is the reason why there is another update is such short order from the previous update in CRAN.  Thank you for your understanding.
 
 ## Test environments
 
-* Ubuntu 18.04.2 LTS, R 3.6.2
-* Ubuntu 14.04 (on travis-ci)
+* macOS M1.     R: 4.2.1
+* macOS         R: Release
+* Windows       R: Release
+* Windows       R: 3.6
+* Ubuntu 18.04  R: Release
+* Ubuntu 18.04  R: Devel
 
 ## R CMD check results
+
 * 0 errors | 0 warnings | 0 notes
+
+## revdepcheck results
+
+We checked 2 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+
+ * We saw 0 new problems
+ * We failed to check 0 packages
diff --git a/revdep/.gitignore b/revdep/.gitignore
@@ -3,3 +3,6 @@ data.sqlite
 library
 checks.rds
 failures.md
+checks.noindex/
+library.noindex/
+cran.md
diff --git a/revdep/README.md b/revdep/README.md
@@ -1,60 +1,24 @@
 # Platform
 
-|field    |value                        |
-|:--------|:----------------------------|
-|version  |R version 3.6.2 (2019-12-12) |
-|os       |Ubuntu 18.04.3 LTS           |
-|system   |x86_64, linux-gnu            |
-|ui       |RStudio                      |
-|language |en_US:en                     |
-|collate  |en_US.UTF-8                  |
-|ctype    |en_US.UTF-8                  |
-|tz       |America/Winnipeg             |
-|date     |2020-02-06                   |
+|field    |value                                            |
+|:--------|:------------------------------------------------|
+|version  |R version 4.2.1 (2022-06-23)                     |
+|os       |macOS Ventura 13.1                               |
+|system   |aarch64, darwin20                                |
+|ui       |RStudio                                          |
+|language |(EN)                                             |
+|collate  |en_US.UTF-8                                      |
+|ctype    |en_US.UTF-8                                      |
+|tz       |America/Chicago                                  |
+|date     |2023-01-17                                       |
+|rstudio  |2022.12.0-preview+330 Elsbeth Geranium (desktop) |
+|pandoc   |2.11 @ /Users/edgar/opt/anaconda3/bin/pandoc     |
 
 # Dependencies
 
-|package     |old      |new      |Δ  |
-|:-----------|:--------|:--------|:--|
-|tidypredict |0.4.3    |0.4.4    |*  |
-|assertthat  |0.2.1    |0.2.1    |   |
-|BH          |1.72.0-3 |1.72.0-3 |   |
-|cli         |2.0.1    |2.0.1    |   |
-|crayon      |1.3.4    |1.3.4    |   |
-|digest      |0.6.23   |0.6.23   |   |
-|dplyr       |0.8.4    |0.8.4    |   |
-|ellipsis    |0.3.0    |0.3.0    |   |
-|evaluate    |0.14     |0.14     |   |
-|fansi       |0.4.1    |0.4.1    |   |
-|generics    |0.0.2    |0.0.2    |   |
-|glue        |1.3.1    |1.3.1    |   |
-|highr       |0.8      |0.8      |   |
-|knitr       |1.28     |1.28     |   |
-|magrittr    |1.5      |1.5      |   |
-|markdown    |1.1      |1.1      |   |
-|mime        |0.9      |0.9      |   |
-|pillar      |1.4.3    |1.4.3    |   |
-|pkgconfig   |2.0.3    |2.0.3    |   |
-|plogr       |0.2.0    |0.2.0    |   |
-|purrr       |0.3.3    |0.3.3    |   |
-|R6          |2.4.1    |2.4.1    |   |
-|Rcpp        |1.0.3    |1.0.3    |   |
-|rlang       |0.4.4    |0.4.4    |   |
-|stringi     |1.4.5    |1.4.5    |   |
-|stringr     |1.4.0    |1.4.0    |   |
-|tibble      |2.1.3    |2.1.3    |   |
-|tidyselect  |1.0.0    |1.0.0    |   |
-|utf8        |1.1.4    |1.1.4    |   |
-|vctrs       |0.2.2    |0.2.2    |   |
-|xfun        |0.12     |0.12     |   |
-|yaml        |2.2.1    |2.2.1    |   |
+|package     |old   |new        |Δ  |
+|:-----------|:-----|:----------|:--|
+|tidypredict |0.4.9 |0.4.9.9001 |*  |
 
 # Revdeps
 
-## Failed to check (2)
-
-|package    |version |error |warning |note |
-|:----------|:-------|:-----|:-------|:----|
-|modeldb    |?       |      |        |     |
-|tidymodels |?       |      |        |     |
-