transition from add_tailor(prop) and method
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
commented
Sep 30, 2024
| @@ -178,8 +176,20 @@ test_that("can use `fit_resamples()` with a workflow - postprocessor (requires t | |||
| seed <- generate_seeds(TRUE, 1)[[1]] | |||
| old_kind <- RNGkind()[[1]] | |||
| assign(".Random.seed", seed, envir = globalenv()) | |||
| withr::defer(RNGkind(kind = old_kind)) | |||
There was a problem hiding this comment.
An RNG state oddity—without it, tests elsewhere in the test suite begin failing with RNG changes.
| @@ -201,7 +211,7 @@ test_that("can use `fit_resamples()` with a workflow - postprocessor (no trainin | |||
| parsnip::linear_reg() | |||
| ) %>% | |||
| workflows::add_tailor( | |||
| tailor::tailor("regression") %>% tailor::adjust_numeric_range(lower_limit = 1) | |||
| tailor::tailor() %>% tailor::adjust_numeric_range(lower_limit = 1) | |||
There was a problem hiding this comment.
I removed the deprecated type argument in tailor code I was editing and went ahead and did it in the last remaining couple places.
| wflow_preds <- predict(wflow_res, rsample::assessment(split)) | ||
|
|
||
| expect_equal(last_fit_preds[".pred"], wflow_preds) | ||
| }) | ||
|
|
||
| test_that("can use `last_fit()` with a workflow - postprocessor (requires training)", { | ||
| test_that("can use `last_fit()` with a workflow - postprocessor (does not require training)", { |
There was a problem hiding this comment.
This tests the same thing it used to—it was just previously mislabeled.
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates related to tidymodels/workflows#262 -- transitions away from the
propandmethodarguments toadd_tailor()to a separate argument for the calibration set and uses the renamed helpers from workflows.