Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memdb: refactor code of art to make it more understandable #1508

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

cfzjywxk
Copy link
Contributor

Some refactor work to make the code of new ART implementation more understandable.

@cfzjywxk cfzjywxk added the enhancement New feature or request label Nov 21, 2024
@cfzjywxk cfzjywxk requested review from you06 and ekexium November 21, 2024 10:15
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 27, 2024
@you06
Copy link
Contributor

you06 commented Dec 16, 2024

@ekexium @zyguan PTAL

Copy link

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
Copy link

ti-chi-bot bot commented Dec 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-27 07:11:36.356380223 +0000 UTC m=+620483.976034739: ☑️ agreed by you06.
  • 2024-12-16 10:42:34.781667223 +0000 UTC m=+867144.870469765: ☑️ agreed by ekexium.

@ti-chi-bot ti-chi-bot bot merged commit 43d2db7 into tikv:master Dec 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. enhancement New feature or request lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants