[close #671] remove shadowing of gRPC and netty #673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Upgrade commons-codec as well
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
============================================
- Coverage 38.26% 34.81% -3.45%
+ Complexity 1630 1355 -275
============================================
Files 278 266 -12
Lines 17521 14274 -3247
Branches 1995 1606 -389
============================================
- Hits 6705 4970 -1735
+ Misses 10148 8868 -1280
+ Partials 668 436 -232 ☔ View full report in Codecov by Sentry. |
…owing-of-grpc-and-netty Signed-off-by: iosmanthus <[email protected]>
pingyu
approved these changes
Mar 28, 2024
auto-merge was automatically disabled
March 28, 2024 08:04
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus [email protected]
What problem does this PR solve?
Issue Number: close #671