Skip to content

Commit

Permalink
Address the comments
Browse files Browse the repository at this point in the history
Signed-off-by: JmPotato <[email protected]>
  • Loading branch information
JmPotato committed Mar 6, 2023
1 parent 2f3d845 commit 2aa3863
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pkg/mcs/resource_manager/server/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ import (

const (
defaultName = "Resource Manager"
defaultBackendEndpoints = "http://127.0.0.1:3379"
defaultListenAddr = "127.0.0.1:3380"
defaultBackendEndpoints = "http://127.0.0.1:2379"
defaultListenAddr = "127.0.0.1:2379"
defaultEnableGRPCGateway = true

defaultLogFormat = "text"
Expand Down
4 changes: 2 additions & 2 deletions pkg/mcs/resource_manager/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const (
// resourceManagerKeyspaceGroupPrimaryElectionPrefix defines the key prefix for keyspace group primary election.
// The entire key is in the format of "/pd/<cluster-id>/microservice/resource_manager/keyspace-group-XXXXX/primary"
// in which XXXXX is 5 digits integer with leading zeros. For now we use 0 as the default cluster id.
resourceManagerKeyspaceGroupPrimaryElectionPrefix = "/pd/0/microservice/resource_manager/keyspace-group-"
resourceManagerKeyspaceGroupPrimaryElectionPrefix = "/pd/0/microservice/resource-manager/keyspace-group-"
// defaultGRPCGracefulStopTimeout is the default timeout to wait for grpc server to gracefully stop
defaultGRPCGracefulStopTimeout = 5 * time.Second
// defaultHTTPGracefulShutdownTimeout is the default timeout to wait for http server to gracefully shutdown
Expand Down Expand Up @@ -169,7 +169,7 @@ func (s *Server) campaignLeader() {
s.participant.ResetLeader()
})

// maintain the the leadership, after this, Resource Manager could be ready to provide service.
// maintain the leadership, after this, Resource Manager could be ready to provide service.
s.participant.KeepLeader(ctx)
log.Info("campaign resource manager primary ok", zap.String("campaign-resource-manager-primary-name", s.participant.Member().Name))

Expand Down

0 comments on commit 2aa3863

Please sign in to comment.