Skip to content

Commit

Permalink
update TODO
Browse files Browse the repository at this point in the history
Signed-off-by: lhy1024 <[email protected]>
  • Loading branch information
lhy1024 committed Nov 22, 2023
1 parent 129e348 commit 792f26c
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions pkg/schedule/schedulers/balance_region.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ var (
type balanceRegionSchedulerConfig struct {
Name string `json:"name"`
Ranges []core.KeyRange `json:"ranges"`
// TODO: whether to support reload it?
// Maybe we need to ensure whether scatter-range-scheduler?
// TODO: When we prepare to use Ranges, we will need to implement the ReloadConfig function for this scheduler.
}

type balanceRegionScheduler struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/schedule/schedulers/label.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ var (
type labelSchedulerConfig struct {
Name string `json:"name"`
Ranges []core.KeyRange `json:"ranges"`
// TODO: whether to support reload it?
// TODO: When we prepare to use Ranges, we will need to implement the ReloadConfig function for this scheduler.
}

type labelScheduler struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/schedule/schedulers/random_merge.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ var (
type randomMergeSchedulerConfig struct {
Name string `json:"name"`
Ranges []core.KeyRange `json:"ranges"`
// TODO: whether to support reload it?
// TODO: When we prepare to use Ranges, we will need to implement the ReloadConfig function for this scheduler.
}

type randomMergeScheduler struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/schedule/schedulers/shuffle_leader.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var (
type shuffleLeaderSchedulerConfig struct {
Name string `json:"name"`
Ranges []core.KeyRange `json:"ranges"`
// TODO: whether to support reload it?
// TODO: When we prepare to use Ranges, we will need to implement the ReloadConfig function for this scheduler.
}

type shuffleLeaderScheduler struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/schedule/schedulers/transfer_witness_leader.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const (
// TransferWitnessLeaderBatchSize is the number of operators to to transfer
// leaders by one scheduling
transferWitnessLeaderBatchSize = 3
// TODO: whether to support reload it?
// TODO: When we prepare to use Ranges, we will need to implement the ReloadConfig function for this scheduler.
// TransferWitnessLeaderRecvMaxRegionSize is the max number of region can receive
// TODO: make it a reasonable value
transferWitnessLeaderRecvMaxRegionSize = 10000
Expand Down

0 comments on commit 792f26c

Please sign in to comment.