address comments

Signed-off-by: Ryan Leung <[email protected]>
tikv · Jan 31, 2024 · ae3d78b · ae3d78b
1 parent bdcd475
commit ae3d78b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/server/forward.go b/server/forward.go
@@ -143,7 +143,6 @@ func (s *GrpcServer) forwardTSO(stream pdpb.PD_TsoServer) error {
 				cancelForward()
 			}
 
-			s.closeDelegateClient(lastForwardedHost)
 			clientConn, err := s.getDelegateClient(s.ctx, forwardedHost)
 			if err != nil {
 				tsoStreamErr = errors.WithStack(err)
@@ -378,6 +377,7 @@ func (s *GrpcServer) closeDelegateClient(forwardedHost string) {
 		return
 	}
 	client.(*grpc.ClientConn).Close()
+	log.Debug("close delegate client connection", zap.String("forwarded-host", forwardedHost))
 }
 
 func (s *GrpcServer) isLocalRequest(host string) bool {

diff --git a/server/grpc_service.go b/server/grpc_service.go
@@ -1332,7 +1332,6 @@ func (s *GrpcServer) RegionHeartbeat(stream pdpb.PD_RegionHeartbeatServer) error
 					cancel()
 				}
 
-				s.closeDelegateClient(lastForwardedSchedulingHost)
 				client, err := s.getDelegateClient(s.ctx, forwardedSchedulingHost)
 				if err != nil {
 					errRegionHeartbeatClient.Inc()