Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Introduce the service registry #5779

Merged
merged 3 commits into from
Dec 14, 2022
Merged

*: Introduce the service registry #5779

merged 3 commits into from
Dec 14, 2022

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 13, 2022

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

Issue Number: Ref #5766

Also part of #5761

What is changed and how does it work?

Introduce the service registry:
- Provide a new way to initial external service
- Supports gRPC and HTTP API both

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 13, 2022
@nolouch nolouch requested review from rleungx, CabinfeverB and lhy1024 and removed request for JmPotato and disksing December 13, 2022 11:47
@codecov
Copy link

codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

Base: 75.56% // Head: 75.59% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (c6ac96b) compared to base (ad1cc2d).
Patch coverage: 77.27% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5779      +/-   ##
==========================================
+ Coverage   75.56%   75.59%   +0.03%     
==========================================
  Files         329      330       +1     
  Lines       32961    32992      +31     
==========================================
+ Hits        24907    24941      +34     
- Misses       5900     5903       +3     
+ Partials     2154     2148       -6
Flag Coverage Δ
unittests 75.59% <77.27%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/autoscaling/service.go 100.00% <ø> (ø)
pkg/dashboard/dashboard.go 90.00% <ø> (ø)
pkg/id/id.go 83.05% <ø> (ø)
pkg/id/metrics.go 100.00% <ø> (ø)
pkg/mock/mockcluster/mockcluster.go 93.94% <ø> (ø)
pkg/storage/endpoint/config.go 76.47% <ø> (ø)
pkg/storage/endpoint/endpoint.go 100.00% <ø> (ø)
pkg/storage/endpoint/external_timestamp.go 55.55% <ø> (ø)
pkg/storage/endpoint/gc_key_space.go 66.66% <ø> (ø)
pkg/storage/endpoint/gc_safe_point.go 70.83% <ø> (ø)
... and 81 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

rleungx
rleungx reviewed Dec 14, 2022
View reviewed changes
server/util.go
Comment on lines +252 to +255
// Deprecated
router.Path("/pd/health").Handler(handler)
// Deprecated
router.Path("/pd/ping").Handler(handler)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to keep these?

Copy link
Contributor Author

@nolouch nolouch Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there is still has dependency. we do not have relative test, so I keep it in here.

rleungx
rleungx approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2022
@nolouch
Copy link
Contributor Author

nolouch commented Dec 14, 2022

PTAL @lhy1024 @CabinfeverB

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2022
@nolouch
Merge remote-tracking branch 'origin/master' into add-registry
b4df235 
Conflicts:
	server/server.go
	server/util.go
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2022
lhy1024
lhy1024 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

pkg/msc/docs.go Show resolved Hide resolved
pkg/msc/registry/registry.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 14, 2022
@nolouch
address comments
c6ac96b 
Signed-off-by: nolouch <[email protected]>
@nolouch
Copy link
Contributor Author

nolouch commented Dec 14, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c6ac96b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2022
@ti-chi-bot ti-chi-bot merged commit 6ada022 into tikv:master Dec 14, 2022
@nolouch nolouch deleted the add-registry branch December 14, 2022 17:56
@nolouch nolouch mentioned this pull request Dec 19, 2022
Open
18 tasks
binshi-bing
binshi-bing reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@binshi-bing binshi-bing mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binshi-bing binshi-bing binshi-bing left review comments

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@CabinfeverB CabinfeverB Awaiting requested review from CabinfeverB

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nolouch @ti-chi-bot @lhy1024 @rleungx @binshi-bing