Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move tso to pkg #5901

Merged
merged 2 commits into from
Feb 3, 2023
Merged

*: move tso to pkg #5901

merged 2 commits into from
Feb 3, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 2, 2023

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #5836.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 2, 2023
@rleungx rleungx requested a review from lhy1024 February 2, 2023 09:09
@rleungx rleungx removed the request for review from disksing February 2, 2023 09:09
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 75.76% // Head: 75.77% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c5203c4) compared to base (7fb70d1).
Patch has no changes to coverable lines.

❗ Current head c5203c4 differs from pull request most recent head 72226b0. Consider uploading reports for the commit 72226b0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5901   +/-   ##
=======================================
  Coverage   75.76%   75.77%           
=======================================
  Files         343      343           
  Lines       35022    34993   -29     
=======================================
- Hits        26534    26515   -19     
+ Misses       6226     6220    -6     
+ Partials     2262     2258    -4     
Flag Coverage Δ
unittests 75.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tso/allocator_manager.go 65.32% <ø> (ø)
pkg/tso/filter.go 75.00% <ø> (ø)
pkg/tso/global_allocator.go 61.25% <ø> (ø)
pkg/tso/local_allocator.go 78.37% <ø> (ø)
pkg/tso/metrics.go 100.00% <ø> (ø)
pkg/tso/tso.go 71.34% <ø> (ø)
server/grpc_service.go 49.42% <ø> (+0.07%) ⬆️
server/handler.go 52.88% <ø> (-0.39%) ⬇️
server/server.go 74.74% <ø> (-0.51%) ⬇️
tests/cluster.go 79.20% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2023
@JmPotato
Copy link
Member

JmPotato commented Feb 2, 2023

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c5203c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2023
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@binshi-bing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we move server/tso/* to pkg/mcs/tso/? just confirm. Moving to pkg/tso makes sense to me too, as it is the library shared by tso in all-in-one pd and tso microservice, and we put tso microservice specific code in pkg/mc/tso.
@rleungx @JmPotato

@rleungx
Copy link
Member Author

rleungx commented Feb 3, 2023

shall we move server/tso/* to pkg/mcs/tso/? just confirm. Moving to pkg/tso makes sense to me too, as it is the library shared by tso in all-in-one pd and tso microservice, and we put tso microservice specific code in pkg/mc/tso. @rleungx @JmPotato

IMO, the tso microservice related code should be put into pkg/mcs/tso, the common logic should be put into /pkg.

@ti-chi-bot ti-chi-bot merged commit 248b3f0 into tikv:master Feb 3, 2023
@rleungx rleungx deleted the tso-pkg branch February 3, 2023 01:54
ti-chi-bot added a commit that referenced this pull request Feb 6, 2023
ref #5839, ref #5901

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants