Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: move service name to utils/constant.go #6172

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 16, 2023

What problem does this PR solve?

Issue Number: Ref #5836.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024 lhy1024 requested review from JmPotato and rleungx March 16, 2023 08:39
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue labels Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (7a0ce10) 74.46% compared to head (8a52699) 74.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6172      +/-   ##
==========================================
+ Coverage   74.46%   74.53%   +0.06%     
==========================================
  Files         393      393              
  Lines       38519    38519              
==========================================
+ Hits        28685    28711      +26     
+ Misses       7288     7274      -14     
+ Partials     2546     2534      -12     
Flag Coverage Δ
unittests 74.53% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/resource_manager/server/server.go 59.22% <100.00%> (ø)
pkg/mcs/tso/server/server.go 51.46% <100.00%> (ø)
server/grpc_service.go 51.98% <100.00%> (+0.29%) ⬆️
server/server.go 75.51% <100.00%> (+0.97%) ⬆️
tests/cluster.go 79.80% <100.00%> (ø)

... and 23 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2023
@rleungx
Copy link
Member

rleungx commented Mar 16, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8a52699

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@ti-chi-bot ti-chi-bot merged commit a330f0b into tikv:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants