Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: support advertise address #6212

Merged
merged 3 commits into from
Mar 23, 2023
Merged

mcs: support advertise address #6212

merged 3 commits into from
Mar 23, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 23, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #5836.

What is changed and how does it work?

This PR supports the advertise address for tso server and resource manager server.

Check List

Tests

  • Unit test

Release note

None.

@rleungx
support advertise address
245c657 
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • binshi-bing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 23, 2023
@ti-chi-bot ti-chi-bot requested review from HunDunDM and nolouch March 23, 2023 03:50
@rleungx rleungx requested review from binshi-bing and JmPotato and removed request for nolouch, HunDunDM and binshi-bing March 23, 2023 03:52
@rleungx rleungx marked this pull request as ready for review March 23, 2023 05:09
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2023
@rleungx
add unit test
d830adb 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the support-advertise-addr branch from a010623 to d830adb Compare March 23, 2023 05:11
binshi-bing
binshi-bing approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/mcs/tso/server/server.go
@@ -574,7 +574,7 @@ func (s *Server) startServer() (err error) {

s.participant = member.NewParticipant(s.etcdClient)
s.participant.InitInfo(uniqueName, uniqueID, fmt.Sprintf(tsoSvcDiscoveryPrefixFormat, s.clusterID, mcsutils.DefaultKeyspaceID),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add AdvertiseListenAddr to tsopb.Participant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that tsopb.Participant just need to store AdvertiseListenAddr as ListenAddr for this case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. There is no need to change the definition of Participant.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2023
@rleungx
small changes
47634f3 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the support-advertise-addr branch from 1fac067 to 47634f3 Compare March 23, 2023 05:36
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 47634f3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2023
@ti-chi-bot ti-chi-bot merged commit f102703 into tikv:master Mar 23, 2023
@rleungx rleungx deleted the support-advertise-addr branch March 23, 2023 06:31
@rleungx rleungx mentioned this pull request Mar 23, 2023
Merged
ti-chi-bot pushed a commit that referenced this pull request Mar 23, 2023
@rleungx
mcs: remove advertise backend endpoint parameters (#6215)
f15257a 
ref #5836, ref #6212

Signed-off-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@binshi-bing binshi-bing binshi-bing approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @ti-chi-bot @JmPotato @binshi-bing