Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: put the operator related logic together #6490

Merged
merged 1 commit into from
May 23, 2023
Merged

*: put the operator related logic together #6490

merged 1 commit into from
May 23, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 19, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Part of #6418. Need to merge #6489 first.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • binshi-bing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 19, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and JmPotato May 19, 2023 06:57
@rleungx rleungx requested review from nolouch and removed request for HunDunDM May 19, 2023 06:58
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 89.18% and project coverage change: +0.18 🎉

Comparison is base (4725351) 74.99% compared to head (2389f0c) 75.18%.

❗ Current head 2389f0c differs from pull request most recent head e4fe4b8. Consider uploading reports for the commit e4fe4b8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6490      +/-   ##
==========================================
+ Coverage   74.99%   75.18%   +0.18%     
==========================================
  Files         410      410              
  Lines       41893    41840      -53     
==========================================
+ Hits        31417    31456      +39     
+ Misses       7717     7643      -74     
+ Partials     2759     2741      -18
Flag Coverage Δ
unittests 75.18% <89.18%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/keyspace/keyspace.go 61.75% <ø> (ø)
pkg/schedule/checker/checker_controller.go 80.00% <ø> (ø)
pkg/schedule/checker/joint_state_checker.go 57.89% <ø> (ø)
pkg/schedule/checker/learner_checker.go 72.72% <ø> (ø)
pkg/schedule/checker/merge_checker.go 70.99% <ø> (ø)
pkg/schedule/checker/priority_inspector.go 81.08% <ø> (ø)
pkg/schedule/checker/replica_checker.go 67.80% <ø> (ø)
pkg/schedule/checker/replica_strategy.go 86.00% <ø> (ø)
pkg/schedule/checker/rule_checker.go 82.41% <ø> (ø)
pkg/schedule/checker/split_checker.go 68.18% <ø> (ø)
... and 43 more

... and 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rleungx rleungx mentioned this pull request May 19, 2023
Merged
lhy1024
lhy1024 reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix conflict

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023
@rleungx rleungx force-pushed the move-opcontroller branch from 2389f0c to ab83ecb Compare May 22, 2023 10:24
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023
@rleungx rleungx force-pushed the move-opcontroller branch from ab83ecb to e4fe4b8 Compare May 22, 2023 10:25
@rleungx rleungx requested a review from lhy1024 May 22, 2023 10:30
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2023
nolouch
nolouch approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nolouch
nolouch approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2023
@nolouch
Copy link
Contributor

nolouch commented May 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e4fe4b8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2023
@ti-chi-bot ti-chi-bot bot merged commit a14f38f into tikv:master May 23, 2023
@rleungx rleungx deleted the move-opcontroller branch May 23, 2023 02:53
ti-chi-bot bot added a commit that referenced this pull request May 23, 2023
@rleungx @ti-chi-bot
*: put the scheduler related logic together (#6491)
f7a4c63 
ref #5839, ref #6418, ref #6490

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx rleungx mentioned this pull request May 26, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
*: put the operator related logic together (tikv#6490)
ea92cba 
ref tikv#5839, ref tikv#6418, ref tikv#6489

Signed-off-by: Ryan Leung <[email protected]>
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx @ti-chi-bot
*: put the scheduler related logic together (tikv#6491)
f701ab9 
ref tikv#5839, ref tikv#6418, ref tikv#6490

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binshi-bing binshi-bing binshi-bing approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @nolouch @lhy1024 @binshi-bing