Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove unnecessary interfaces #6551

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 2, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

After this PR, operator controller doesn't need to rely on the raft cluster anymore.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 June 2, 2023 04:19
@rleungx rleungx requested review from JmPotato and nolouch and removed request for disksing and lhy1024 June 2, 2023 04:19
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 86.59% and project coverage change: -0.03 ⚠️

Comparison is base (107b2a0) 74.64% compared to head (4b075f0) 74.61%.

❗ Current head 4b075f0 differs from pull request most recent head 3780edc. Consider uploading reports for the commit 3780edc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6551      +/-   ##
==========================================
- Coverage   74.64%   74.61%   -0.03%     
==========================================
  Files         415      415              
  Lines       42581    42549      -32     
==========================================
- Hits        31783    31750      -33     
- Misses       7994     8002       +8     
+ Partials     2804     2797       -7     
Flag Coverage Δ
unittests 74.61% <86.59%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/core/basic_cluster.go 93.75% <ø> (ø)
pkg/core/region.go 88.97% <ø> (ø)
pkg/mock/mockcluster/mockcluster.go 93.84% <ø> (+0.80%) ⬆️
pkg/schedule/schedulers/grant_hot_region.go 54.60% <ø> (ø)
pkg/schedule/schedulers/grant_leader.go 68.15% <0.00%> (ø)
server/api/region.go 68.14% <0.00%> (ø)
pkg/schedule/operator/step.go 76.60% <55.55%> (ø)
pkg/schedule/operator/operator_controller.go 87.02% <66.66%> (+0.47%) ⬆️
pkg/schedule/coordinator.go 72.72% <90.00%> (-0.13%) ⬇️
pkg/schedule/diagnostic_manager.go 75.78% <90.00%> (+0.52%) ⬆️
... and 14 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rleungx rleungx force-pushed the reduce-interfaces branch from 333613c to c3aa5fd Compare June 2, 2023 09:39
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 5, 2023
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 6, 2023
@nolouch
Copy link
Contributor

nolouch commented Jun 6, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c3aa5fd

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 09dcabe into tikv:master Jun 6, 2023
@rleungx rleungx deleted the reduce-interfaces branch June 6, 2023 09:02
ti-chi-bot bot pushed a commit that referenced this pull request Jun 9, 2023
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants