-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: use individual package for splitter and scatter #6552
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6552 +/- ##
=======================================
Coverage 74.72% 74.72%
=======================================
Files 415 416 +1
Lines 42573 42581 +8
=======================================
+ Hits 31811 31819 +8
+ Misses 7962 7956 -6
- Partials 2800 2806 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: eba0a98
|
Signed-off-by: Ryan Leung <[email protected]>
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 41c52dc
|
ref tikv#5839 Signed-off-by: Ryan Leung <[email protected]>
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
Just refactor to make the dependency clearer.
Check List
Tests
Release note