Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: fix cannot dump trace #7255

Merged
merged 3 commits into from
Oct 26, 2023
Merged

api: fix cannot dump trace #7255

merged 3 commits into from
Oct 26, 2023

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Oct 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #7253

What is changed and how does it work?

api: fix cannot dump trace with dashboard

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    image
    can download:
    image

and with curl:
image

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 25, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Oct 25, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and HunDunDM October 25, 2023 12:29
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Oct 25, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (459671f) to head (138b10b).
Report is 632 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7255      +/-   ##
==========================================
- Coverage   74.34%   74.25%   -0.09%     
==========================================
  Files         446      446              
  Lines       48200    48201       +1     
==========================================
- Hits        35833    35791      -42     
- Misses       9201     9239      +38     
- Partials     3166     3171       +5
Flag Coverage Δ
unittests 74.25% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch
Copy link
Contributor Author

nolouch commented Oct 26, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 138b10b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2023
@nolouch nolouch added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Oct 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit bfc988b into tikv:master Oct 26, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7264.

This was referenced Oct 26, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7265.

@nolouch nolouch deleted the fix-trace branch October 26, 2023 05:44
ti-chi-bot bot pushed a commit that referenced this pull request Oct 26, 2023
@ti-chi-bot @nolouch
api: fix cannot dump trace (#7255) (#7264)
026ac3c 
close #7253

api: fix cannot dump trace with dashboard

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
ti-chi-bot bot added a commit that referenced this pull request Oct 26, 2023
@ti-chi-bot @nolouch @ti-chi-bot
api: fix cannot dump trace (#7255) (#7265)
a54621a 
close #7253

api: fix cannot dump trace with dashboard

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024 lhy1024 mentioned this pull request Aug 21, 2024
Closed
@nolouch nolouch added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Oct 30, 2024
@nolouch
Copy link
Contributor Author

nolouch commented Oct 30, 2024

/run-cherry-picker

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 30, 2024
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#7255
b3e66ec 
close tikv#7253

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8754.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb-dashboard cannot fetch trace for pd
4 participants
@nolouch @ti-chi-bot @lhy1024 @HuSharp