Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: fix checkMembershipCh blocking #7272

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 26, 2023

What problem does this PR solve?

Issue Number: Close #7207

What is changed and how does it work?

After #7254, there are still stuck TestHot because of blocking channel

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
for i in {1..20}
do
	go test -run ^TestHotTestSuite$  github.com/tikv/pd/tests/pdctl/hot
done

Pass all

Release note

None.

@lhy1024 lhy1024 requested review from JmPotato and rleungx October 26, 2023 11:18
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 26, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #7272 (d7bb99f) into master (f9b476d) will increase coverage by 0.14%.
Report is 2 commits behind head on master.
The diff coverage is 80.00%.

❗ Current head d7bb99f differs from pull request most recent head 98c58e6. Consider uploading reports for the commit 98c58e6 to get more accurate results

@@            Coverage Diff             @@
##           master    #7272      +/-   ##
==========================================
+ Coverage   74.28%   74.43%   +0.14%     
==========================================
  Files         446      446              
  Lines       48227    48230       +3     
==========================================
+ Hits        35825    35898      +73     
+ Misses       9229     9169      -60     
+ Partials     3173     3163      -10     
Flag Coverage Δ
unittests 74.43% <80.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 27, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d7bb99f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 67ecd76 into tikv:master Oct 27, 2023
19 checks passed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#7207

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestHotTestSuite is unstable
3 participants