Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Fix resolved ts #7282

Closed
wants to merge 1 commit into from
Closed

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Oct 27, 2023

What problem does this PR solve?

Issue Number: Close #xxx

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 27, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx October 27, 2023 09:39
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
server/config/config.go 78.99% <ø> (ø)
server/core/store.go 80.55% <100.00%> (ø)

... and 29 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Comment on lines 742 to 748
func IsAvailableForMinResolvedTS(s *StoreInfo, state string) bool {
if state == "sync_recover" {
return !s.IsRemoved() && !s.IsTiFlash()
}
// If a store is tombstone or no leader, it is not meaningful for min resolved ts.
// And we will skip tiflash, because it does not report min resolved ts.
return !s.IsRemoved() && !s.IsTiFlash() && s.GetLeaderCount() != 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func IsAvailableForMinResolvedTS(s *StoreInfo, state string) bool {
if state == "sync_recover" {
return !s.IsRemoved() && !s.IsTiFlash()
}
// If a store is tombstone or no leader, it is not meaningful for min resolved ts.
// And we will skip tiflash, because it does not report min resolved ts.
return !s.IsRemoved() && !s.IsTiFlash() && s.GetLeaderCount() != 0
func IsAvailableForMinResolvedTS(s *StoreInfo, state string) bool {
// If a store is tombstone or no leader, it is not meaningful for min resolved ts.
// And we will skip tiflash, because it does not report min resolved ts.
return !s.IsRemoved() && !s.IsTiFlash()

Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2023
@rleungx
Copy link
Member

rleungx commented Sep 13, 2024

dr doesn't use flashback, this PR is no longer needed.

@rleungx rleungx closed this Sep 13, 2024
@HuSharp HuSharp deleted the fix_resolved_ts branch September 13, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants