-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Fix resolved ts #7282
[DNM] Fix resolved ts #7282
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
32b3016
to
24a5e20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 29 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
server/core/store.go
Outdated
func IsAvailableForMinResolvedTS(s *StoreInfo, state string) bool { | ||
if state == "sync_recover" { | ||
return !s.IsRemoved() && !s.IsTiFlash() | ||
} | ||
// If a store is tombstone or no leader, it is not meaningful for min resolved ts. | ||
// And we will skip tiflash, because it does not report min resolved ts. | ||
return !s.IsRemoved() && !s.IsTiFlash() && s.GetLeaderCount() != 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func IsAvailableForMinResolvedTS(s *StoreInfo, state string) bool { | |
if state == "sync_recover" { | |
return !s.IsRemoved() && !s.IsTiFlash() | |
} | |
// If a store is tombstone or no leader, it is not meaningful for min resolved ts. | |
// And we will skip tiflash, because it does not report min resolved ts. | |
return !s.IsRemoved() && !s.IsTiFlash() && s.GetLeaderCount() != 0 | |
func IsAvailableForMinResolvedTS(s *StoreInfo, state string) bool { | |
// If a store is tombstone or no leader, it is not meaningful for min resolved ts. | |
// And we will skip tiflash, because it does not report min resolved ts. | |
return !s.IsRemoved() && !s.IsTiFlash() |
Signed-off-by: husharp <[email protected]>
24a5e20
to
d57de87
Compare
dr doesn't use flashback, this PR is no longer needed. |
What problem does this PR solve?
Issue Number: Close #xxx
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note