Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: tso service should not forward again #7348

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 10, 2023

What problem does this PR solve?

Issue Number: Ref #5836.

What is changed and how does it work?

We don't support tso server forwarding in client so we need to remove the forward logic.

Check List

Tests

  • Unit test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and Yisaer November 10, 2023 06:55
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #7348 (136c200) into master (2c07c24) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7348      +/-   ##
==========================================
+ Coverage   74.48%   74.50%   +0.01%     
==========================================
  Files         446      446              
  Lines       48435    48418      -17     
==========================================
- Hits        36076    36072       -4     
+ Misses       9182     9161      -21     
- Partials     3177     3185       +8     
Flag Coverage Δ
unittests 74.50% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2023
@rleungx
Copy link
Member Author

rleungx commented Nov 10, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 136c200

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit fe8a393 into tikv:master Nov 10, 2023
@rleungx rleungx deleted the remove-forward branch November 10, 2023 08:54
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5836

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants