Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: speed up and stabilize tests #7417

Merged
merged 2 commits into from
Nov 23, 2023
Merged

mcs: speed up and stabilize tests #7417

merged 2 commits into from
Nov 23, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 23, 2023

What problem does this PR solve?

Issue Number: Close #7399.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 23, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and lhy1024 November 23, 2023 03:45
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 23, 2023
@rleungx rleungx requested review from CabinfeverB and removed request for HunDunDM November 23, 2023 03:48
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2023
CabinfeverB
CabinfeverB approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

tests/integrations/mcs/scheduling/server_test.go
@@ -96,6 +96,10 @@ func (suite *serverTestSuite) TestAllocID() {
func (suite *serverTestSuite) TestAllocIDAfterLeaderChange() {
re := suite.Require()
re.NoError(failpoint.Enable("github.com/tikv/pd/pkg/mcs/scheduling/server/fastUpdateMember", `return(true)`))
pd2, err := suite.cluster.Join(suite.ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why modify this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous:

--- PASS: TestServerTestSuite (35.10s)
    --- PASS: TestServerTestSuite/TestAllocID (0.29s)
    --- PASS: TestServerTestSuite/TestAllocIDAfterLeaderChange (1.83s)
    --- PASS: TestServerTestSuite/TestDynamicSwitch (0.77s)
    --- PASS: TestServerTestSuite/TestForwardRegionHeartbeat (5.19s)
    --- PASS: TestServerTestSuite/TestForwardStoreHeartbeat (0.19s)
    --- PASS: TestServerTestSuite/TestPrimaryChange (0.37s)
    --- PASS: TestServerTestSuite/TestSchedulerSync (3.94s)
    --- PASS: TestServerTestSuite/TestStoreLimit (5.71s)

after:

--- PASS: TestServerTestSuite (27.96s)
    --- PASS: TestServerTestSuite/TestAllocID (0.29s)
    --- PASS: TestServerTestSuite/TestAllocIDAfterLeaderChange (10.34s)
    --- PASS: TestServerTestSuite/TestDynamicSwitch (0.78s)
    --- PASS: TestServerTestSuite/TestForwardRegionHeartbeat (5.20s)
    --- PASS: TestServerTestSuite/TestForwardStoreHeartbeat (0.19s)
    --- PASS: TestServerTestSuite/TestPrimaryChange (0.39s)
    --- PASS: TestServerTestSuite/TestSchedulerSync (3.95s)
    --- PASS: TestServerTestSuite/TestStoreLimit (5.72s)

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 23, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #7417 (9ee6b01) into master (8198735) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7417      +/-   ##
==========================================
- Coverage   74.21%   74.21%   -0.01%     
==========================================
  Files         451      451              
  Lines       49385    49385              
==========================================
- Hits        36652    36650       -2     
- Misses       9461     9462       +1     
- Partials     3272     3273       +1
Flag Coverage Δ
unittests 74.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
Copy link
Member Author

rleungx commented Nov 23, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9ee6b01

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2023
@ti-chi-bot ti-chi-bot bot merged commit fc578aa into tikv:master Nov 23, 2023
23 checks passed
@rleungx rleungx deleted the stable-test13 branch November 23, 2023 09:18
@rleungx rleungx changed the title mcs: speed up and stablize tests mcs: speed up and stabilize tests Nov 23, 2023
@rleungx rleungx mentioned this pull request Nov 30, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
mcs: speed up and stablize tests (tikv#7417)
334a69d 
close tikv#7399

Signed-off-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestForwardStoreHeartbeat is unstable
3 participants
@rleungx @lhy1024 @CabinfeverB