schedule: fix panic when switching placement rules (#7415)

[ti-chi-bot]

This is an automated cherry-pick of #7415

What problem does this PR solve?

Issue Number: Close #7414.

What is changed and how does it work?

When we going to disable the placement rule, we might first check:

pd/pkg/schedule/checker/checker_controller.go

Line 89 in 8e6dcfb

if c.conf.IsPlacementRulesEnabled() {

Before we change it, the value is true. But when we call:

pd/pkg/schedule/checker/checker_controller.go

Line 102 in 8e6dcfb

fit := c.priorityInspector.Inspect(region)

pd/pkg/schedule/checker/priority_inspector.go

Lines 64 to 74 in 8e6dcfb

	func (p *PriorityInspector) Inspect(region *core.RegionInfo) (fit *placement.RegionFit) {
	var makeupCount int
	if p.conf.IsPlacementRulesEnabled() {
	makeupCount, fit = p.inspectRegionInPlacementRule(region)
	} else {
	makeupCount = p.inspectRegionInReplica(region)
	}
	priority := 0 - makeupCount
	p.addOrRemoveRegion(priority, region.GetID())
	return
	}

The value can be changed to false. So the fit will be nil in this case.

Check List

Tests

• Unit test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• CabinfeverB
• lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (52966d8) 74.85% compared to head (710e0a9) 74.94%.

❗ Current head 710e0a9 differs from pull request most recent head 0885ce9. Consider uploading reports for the commit 0885ce9 to get more accurate results

Files	Patch %	Lines
pkg/schedule/checker/rule_checker.go	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release-7.1    #7424      +/-   ##
===============================================
+ Coverage        74.85%   74.94%   +0.08%     
===============================================
  Files              409      409              
  Lines            41354    41334      -20     
===============================================
+ Hits             30955    30976      +21     
+ Misses            7683     7650      -33     
+ Partials          2716     2708       -8     

Flag	Coverage Δ
unittests	74.94% <0.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rleungx]

/merge

[ti-chi-bot]

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 710e0a9

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.