Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add store and region interface in scheduling server #7754

Merged
merged 8 commits into from
Jan 31, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jan 24, 2024

What problem does this PR solve?

Issue Number: Ref #5839

What is changed and how does it work?

  1. move store and region response to another pkg
  2. add store and region interface in the scheduling server

Check List

Tests

  • Unit test
  • Manual test
    image
    image
    image
    image

Release note

None.

Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 requested a review from rleungx January 24, 2024 07:53
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #7754 (a2dbacc) into master (357ad3f) will increase coverage by 0.09%.
The diff coverage is 86.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7754      +/-   ##
==========================================
+ Coverage   73.52%   73.62%   +0.09%     
==========================================
  Files         430      432       +2     
  Lines       47745    47806      +61     
==========================================
+ Hits        35106    35195      +89     
+ Misses       9627     9598      -29     
- Partials     3012     3013       +1     
Flag Coverage Δ
unittests 73.62% <86.75%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

pkg/response/store.go Outdated Show resolved Hide resolved
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jan 25, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 29, 2024
@rleungx
Copy link
Member

rleungx commented Jan 31, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 6fe91d6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 31, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4e48f5b into tikv:master Jan 31, 2024
25 of 26 checks passed
@lhy1024 lhy1024 deleted the sche-interface branch February 1, 2024 08:05
rleungx added a commit to rleungx/pd that referenced this pull request Feb 26, 2024
* mcs: close the connection to avoid retrying to connect (tikv#7757)

ref tikv#5839

Signed-off-by: Ryan Leung <[email protected]>

* mcs: add store and region interface in scheduling server (tikv#7754)

ref tikv#5839

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <[email protected]>

* remove test

Signed-off-by: lhy1024 <[email protected]>

* fix test

Signed-off-by: lhy1024 <[email protected]>

---------

Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants