Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

member: avoid frequent campaign times (#7301) #7790

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7301

What problem does this PR solve?

Issue Number: Close #7251, ref #7377

What is changed and how does it work?

when pd leader frequently campaign leader, but etcd leader did not change.
We need to prevent this pd leader campaign and resign to another member.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-7301-to-release-7.5 branch from 9e4957d to 2dd345c Compare February 1, 2024 09:28
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #7790 (850001a) into release-7.5 (a276843) will decrease coverage by 0.16%.
Report is 4 commits behind head on release-7.5.
The diff coverage is 56.16%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7790      +/-   ##
===============================================
- Coverage        74.62%   74.47%   -0.16%     
===============================================
  Files              443      443              
  Lines            47923    47980      +57     
===============================================
- Hits             35764    35733      -31     
- Misses            8996     9060      +64     
- Partials          3163     3187      +24     
Flag Coverage Δ
unittests 74.47% <56.16%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2024
@HuSharp
Copy link
Member

HuSharp commented Feb 2, 2024

@JmPotato @rleungx PTAL, thx!

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 2, 2024
@JmPotato
Copy link
Member

JmPotato commented Feb 2, 2024

Should #7501 be cherry-picked as well?

@HuSharp
Copy link
Member

HuSharp commented Feb 2, 2024

Should #7501 be cherry-picked as well?

Okay, #7566 and #7795 can be cherry-picked at the same time

@HuSharp HuSharp force-pushed the cherry-pick-7301-to-release-7.5 branch from cbb75bd to 850001a Compare February 2, 2024 08:24
@HuSharp HuSharp requested a review from lhy1024 February 2, 2024 08:39
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2024
@JmPotato
Copy link
Member

JmPotato commented Feb 2, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 850001a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit ae19047 into tikv:release-7.5 Feb 2, 2024
20 checks passed
@HuSharp HuSharp deleted the cherry-pick-7301-to-release-7.5 branch February 2, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants