Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use rateLimitCheck to reduce code #8995

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 14, 2025

What problem does this PR solve?

Issue Number: ref #4373

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 14, 2025
@rleungx rleungx force-pushed the use-func branch 2 times, most recently from 7d27af9 to 28b7864 Compare January 14, 2025 09:23
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 14, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 44.85597% with 134 lines in your changes missing coverage. Please review.

Project coverage is 76.33%. Comparing base (ad172c7) to head (487aa63).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8995      +/-   ##
==========================================
- Coverage   76.33%   76.33%   -0.01%     
==========================================
  Files         465      465              
  Lines       70565    70534      -31     
==========================================
- Hits        53867    53840      -27     
+ Misses      13355    13344      -11     
- Partials     3343     3350       +7     
Flag Coverage Δ
unittests 76.33% <44.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested review from lhy1024 and okJiang January 15, 2025 03:17
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 15, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 15, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-15 03:29:18.793527792 +0000 UTC m=+89230.248573943: ☑️ agreed by lhy1024.
  • 2025-01-15 03:58:26.06608662 +0000 UTC m=+90977.521132770: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit dd8df1a into tikv:master Jan 15, 2025
23 of 25 checks passed
@rleungx rleungx deleted the use-func branch January 15, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants