Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/sd: unify the service discovery callbacks within a struct #9014

Merged
merged 3 commits into from
Jan 22, 2025
+166 −84

Use more simple namings

62b7b61
Select commit
Loading
Failed to load commit list.
Merged

client/sd: unify the service discovery callbacks within a struct #9014

Use more simple namings
62b7b61
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 22, 2025 in 0s

79.48% of diff hit (target 76.22%)

View this Pull Request on Codecov

79.48% of diff hit (target 76.22%)

Annotations

Check warning on line 82 in client/servicediscovery/callbacks.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/callbacks.go#L82 

Added line #L82 was not covered by tests

Check warning on line 87 in client/servicediscovery/callbacks.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/callbacks.go#L86-L87 

Added lines #L86 - L87 were not covered by tests

Check warning on line 100 in client/servicediscovery/callbacks.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/callbacks.go#L100 

Added line #L100 was not covered by tests

Check warning on line 104 in client/servicediscovery/mock_service_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/mock_service_discovery.go#L104 

Added line #L104 was not covered by tests

Check warning on line 107 in client/servicediscovery/mock_service_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/mock_service_discovery.go#L107 

Added line #L107 was not covered by tests

Check warning on line 110 in client/servicediscovery/mock_service_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/mock_service_discovery.go#L110 

Added line #L110 was not covered by tests

Check warning on line 785 in client/servicediscovery/service_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/service_discovery.go#L784-L785 

Added lines #L784 - L785 were not covered by tests

Check warning on line 857 in client/servicediscovery/service_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/service_discovery.go#L857 

Added line #L857 was not covered by tests

Check warning on line 972 in client/servicediscovery/service_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/service_discovery.go#L972 

Added line #L972 was not covered by tests

Check warning on line 374 in client/servicediscovery/tso_service_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/servicediscovery/tso_service_discovery.go#L374 

Added line #L374 was not covered by tests
View more details on Codecov