Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: check file header #9015

Merged
merged 1 commit into from
Jan 21, 2025
Merged

*: check file header #9015

merged 1 commit into from
Jan 21, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 20, 2025

What problem does this PR solve?

Issue Number: ref #4322

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jan 20, 2025
@rleungx rleungx requested review from lhy1024 and okJiang and removed request for lhy1024 January 20, 2025 10:06
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2025
lhy1024
lhy1024 reviewed Jan 20, 2025
View reviewed changes
pkg/btree/btree_generic_test.go
@@ -1,4 +1,4 @@
// Copyright 2014-2022 Google Inc.
// Copyright 2022 TiKV Project Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we modify it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reorder to make detection easier

@rleungx rleungx force-pushed the check-header branch 3 times, most recently from 5fc58da to a03a84d Compare January 20, 2025 10:25
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2025
@rleungx rleungx force-pushed the check-header branch 3 times, most recently from 80a2158 to 86d7802 Compare January 20, 2025 10:53
@rleungx
check file header
07ffa49 
Signed-off-by: Ryan Leung <[email protected]>
bufferflies
bufferflies reviewed Jan 20, 2025
View reviewed changes
pkg/utils/grpcutil/grpcutil_test.go
@@ -1,3 +1,17 @@
// Copyright 2019 TiKV Project Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to use 2025 for the new license if the previous header is blank?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I found the new issued years of different files are different.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the file created time, just the same as others.

bufferflies
bufferflies reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgmt

@rleungx
Copy link
Member Author

rleungx commented Jan 21, 2025

/retest

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.29%. Comparing base (604b0d6) to head (07ffa49).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #9015    +/-   ##
========================================
  Coverage   76.28%   76.29%            
========================================
  Files         465      465            
  Lines       70512    70659   +147     
========================================
+ Hits        53792    53910   +118     
- Misses      13372    13399    +27     
- Partials     3348     3350     +2
Flag Coverage Δ
unittests 76.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 21, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-21 03:29:04.932135773 +0000 UTC m=+151472.263055179: ☑️ agreed by JmPotato.
  • 2025-01-21 03:30:03.527493938 +0000 UTC m=+151530.858413342: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 093b841 into tikv:master Jan 21, 2025
25 checks passed
@rleungx rleungx deleted the check-header branch January 21, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato JmPotato approved these changes

@okJiang okJiang Awaiting requested review from okJiang

@bufferflies bufferflies Awaiting requested review from bufferflies

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @JmPotato @lhy1024 @bufferflies