Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: expose etcd's transaction as LowLevelTxn interface to kv.Base #9016

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

storage: expose etcd's transaction as LowLevelTxn interface to kv.Base #9016

wants to merge 3 commits into from
+775 −9

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Jan 20, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #8978
Split out from #8989

What is changed and how does it work?

Exposes etcd's transactoin API to kv.Base layer. The behavior is also simulated in `MemKV` and `LevelDBKV` to provide the same interface.

Check List

Tests

  • Unit test

Code changes

Side effects

  • Increased code complexity

Related changes

Release note

None.

@MyonKeminta
expose etcd's transaction as LowLevelTxn interface to kv.Base, simula…
7f34146 
…te the behavior in memkv and leveldb

Signed-off-by: MyonKeminta <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cabinfeverb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 20, 2025
@MyonKeminta MyonKeminta marked this pull request as ready for review January 20, 2025 10:17
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2025
@MyonKeminta
Fix lint and add comments
413cc45 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
fix errors.toml
29a8470 
Signed-off-by: MyonKeminta <[email protected]>
JmPotato
JmPotato reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for #8919.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MyonKeminta @JmPotato