This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Merge latest from upstream #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR sets the required property on the `name` parameter to false in the `action.yml` I have the VSCode [Github Actions Extension](https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions) installed, it shows that I need to add the parameter 'name' but this is not true. <img width="612" alt="image" src="https://github.com/mobile-dev-inc/action-maestro-cloud/assets/877327/14f76b09-47a1-4bee-bd72-b3e08d5b54c2"> From checking the [params.ts](https://github.com/mobile-dev-inc/action-maestro-cloud/blob/main/params.ts#LL103C1-L103C1) file I think we can set required to false in the `action.yml`.
This reverts commit 2421273.
This PR allows the timeout of the action to be controlled, just like we have today in `maestro cloud` CLI
Adds timeout argument
And add another useful link.
The Maestro GH action returns variables that contain information about the results of the run which can be very useful in CI. These variables are noted in the README, but little information is given as to what those variables will actually contain. This means devs need to run fake CI runs, which take time and money, to see the type of output they're going to get. This PR simply clarifies what type the output variables will be, for those types which are not simply strings, hopefully saving devs time in debugging GH Actions workflows.
* Lots more Robin, with a few Maestro Cloud caveats * Added a canonical list of inputs at the top * Fixed some formatting that the linter was complaining about
Whilst DNS doesn't resolve the new name, revert the API endpoint change from #45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.