Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with #325, the difference in performance with the
safe_lock
is much more noticeable compared to #322 (x4-5 on my machine)this stores only the starting thread instead of a vector of all used threads (which is basically the same)
I can't see a repeatable difference between disabling the lock and letting in detect but both are still possible with this
Performance results from
runtest.jl
: (these numbers vary quite a lot between each run)