[Network] Fix traffic-manager update command. (Azure#4777)

* Fix traffic-manager update command. * Code review feedback.
timwarner-msft · Oct 27, 2017 · 457c606 · 457c606
1 parent 0d16ad7
commit 457c606
Show file tree

Hide file tree

Showing 5 changed files with 163 additions and 87 deletions.
diff --git a/azure-cli.pyproj b/azure-cli.pyproj
@@ -61,7 +61,6 @@
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_add_resourcegroup_transform.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_api_profiles.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_application.py" />
-    <Compile Include="azure-cli-core\azure\cli\core\tests\test_arm.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_cloud.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_command_registration.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_command_with_configured_defaults.py" />
@@ -75,7 +74,6 @@
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_parser.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_profile.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_progress.py" />
-    <Compile Include="azure-cli-core\azure\cli\core\tests\test_resource_id.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_storage_validators.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_telemetry.py" />
     <Compile Include="azure-cli-core\azure\cli\core\tests\test_util.py" />
@@ -86,7 +84,6 @@
     <Compile Include="azure-cli-core\azure\cli\core\_environment.py" />
     <Compile Include="azure-cli-core\azure\cli\core\_help.py" />
     <Compile Include="azure-cli-core\azure\cli\core\_output.py" />
-    <Compile Include="azure-cli-core\azure\cli\core\_pkg_util.py" />
     <Compile Include="azure-cli-core\azure\cli\core\_profile.py" />
     <Compile Include="azure-cli-core\azure\cli\core\_session.py" />
     <Compile Include="azure-cli-core\azure\cli\core\telemetry.py" />

diff --git a/src/command_modules/azure-cli-network/HISTORY.rst b/src/command_modules/azure-cli-network/HISTORY.rst
@@ -6,7 +6,7 @@ Release History
 2.0.18
 ++++++
 * `dns`: Add support for CAA records.
-
+* `traffic-manager profile update`: Fix issue where profiles with endpoints could not be updated.
 
 2.0.17
 ++++++

diff --git a/src/command_modules/azure-cli-network/azure/cli/command_modules/network/custom.py b/src/command_modules/azure-cli-network/azure/cli/command_modules/network/custom.py
@@ -2584,6 +2584,12 @@ def update_traffic_manager_profile(instance, profile_status=None, routing_method
     if monitor_path is not None:
         instance.monitor_config.path = monitor_path
 
+    # TODO: Remove workaround after https://github.com/Azure/azure-rest-api-specs/issues/1940 fixed
+    for endpoint in instance.endpoints:
+        endpoint._validation = {
+            'name': {'readonly': False},
+            'type': {'readonly': False},
+        }
     return instance
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,7 +6,7 @@ Release History @@
 .0.18
     ++++++
     * `dns`: Add support for CAA records.
+    * `traffic-manager profile update`: Fix issue where profiles with endpoints could not be updated.
 .0.17
     ++++++
@@ Expand Down @@