Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiments.ts: disable 'enable-record-ecosystem-meta' #1537

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

niklas-holzwarth-bos-ag

When this experiment is enabled by default, it will produce http timeouts and retries, which cause the pipeline to run extremely slow and fail at the end.

The CLI tries to connect to "host.docker.internal" but the server returns the status code 501 (not implemented), so the cli logs "unexpected output type: record_ecosystem_meta".

This will cause a long timeout (see timestamp) and the action is performed 4 times per dependency, so the entire devops pipeline takes us currently ~16 minutes to run and it also cannot be cancelled.

image

When this experiment is enabled by default, it will produce http timeouts and retries, which cause the pipeline to run extremely slow and fail at the end.
@rhyskoedijk
Copy link
Contributor

rhyskoedijk commented Jan 17, 2025

Thanks @niklas-holzwarth-bos-ag. The experiment is enabled by default as that is what GitHub does.

Looking in to the background of record_ecosystem_meta more, it was introduced in v0.286.0 via dependabot/dependabot-core#10905 and it seems to be primarily for GitHub's own analytics; It probably doesn't add value to the DevOps implementation so I think disabling it is a good call.

Dependabot-CLI main does not currently have a handler for this: https://github.com/dependabot/cli/blob/4e7612fe884683ade8c54ad8fd137fc6da92bb84/internal/server/api.go#L217C1-L248C2

@rhyskoedijk
Copy link
Contributor

rhyskoedijk commented Jan 17, 2025

It is also quite possible that this experiment will be removed and the behavior forced on by default in a future dependabot-core update, which has been the case with many previous experiments.

We will likely need to submit a PR to Dependabot-CLI to add support for record_ecosystem_meta before this happens, else the issue will return and there won't be any way to disable it.

@niklas-holzwarth-bos-ag
Copy link
Author

Hi, thank's a lot for your fast response!
It is unfortunate, that github implements breaking changes in such a way, that the cli does not correctly support it's own implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants