All formats properly handled, code refactor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimetype='application/octet-stream'
return send_from_directory(
app.config['OUTPUT_FOLDER'],
filename,
as_attachment=True,
download_name=filename
)
La route /download/<filename> a été modifiée pour utiliser send_file avec l'option as_attachment=True, ce qui devrait forcer le téléchargement du fichier au lieu de l'ouvrir dans un nouvel onglet.
La route /download/<filename> a été intégrée avec la modification pour utiliser explicitement send_file et définir le type MIME comme un contenu binaire générique, ainsi que le paramètre as_attachment
inclure une gestion explicite des en-têtes HTTP dans la route /download/<filename>, utilisant Flask.Response pour forcer le téléchargement des fichiers.
Le code a été refactorisé pour réduire les redondances, centraliser la gestion des erreurs et simplifier la logique tout en conservant toutes les fonctionnalités.
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.