-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Django to 3.2 and other Python dependencies (#1286) #1300
Update Django to 3.2 and other Python dependencies (#1286) #1300
Conversation
…r for compatibility; update package-lock.json
… to avoid overflow
I think this is ready for review and further testing. Please let me know if you have any other questions. Issue #1286 has a lot of notes and linked resources about the dependency changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, I think this is good to get in and we can create new issues if needed for the createkeys and the roles change (if there isn't one for that yet)
@zqian and @pushyamig, do either of you plan to or want to review this before it's merged? |
@ssciolla please go ahead and merge it if you like |
The PR aims to resolve #1084 and #1286.
I've built with these changes, and everything seems to work so far. I will be looking more closely at each updated dependency to see where it is used, what has changed, and whether I need to do anything special to test it. Any assistance with testing would be appreciated.
To do
requirements.txt
webpack-bundle-tracker
npm
package to ensure compatibility withdjango-webpack-loader
npm install
in repository to updatepackage-lock.json
django-settings-export
,django-model-utils
, anddjango-macros
.Django
,pinax-eventlog
, andpandas
.DEFAULT_AUTO_FIELD
NullBooleanField
usageTesting