Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate use of * as required indicator #437

Open
ssciolla opened this issue Jun 19, 2023 · 1 comment · May be fixed by #597
Open

Evaluate use of * as required indicator #437

ssciolla opened this issue Jun 19, 2023 · 1 comment · May be fixed by #597
Assignees
@jonespm
Labels
accessibility Involves changes intended to improve accessibility Effort: 8 Effort estimated at full day front end Involves changes to the front end (React) application and/or UI

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Jun 19, 2023 •
edited
Loading

I know this is just adding a space here but it looks like using the HTML form validation is recommended over an * both for usage and accessibility.

https://www.accessibility-developer-guide.com/examples/forms/required/#using-html-5-client-side-validations
https://react-bootstrap.netlify.app/docs/forms/validation

Was this not changed just because that's a separate (more effort) issue? We should probably file it as a new issue to fix it in the future.

Originally posted by @jonespm in #435 (comment)
@ssciolla ssciolla added front end Involves changes to the front end (React) application and/or UI accessibility Involves changes intended to improve accessibility labels Jun 19, 2023
@ssciolla ssciolla mentioned this issue Jun 19, 2023
Merged
@jonespm jonespm added the Effort: 8 Effort estimated at full day label Nov 8, 2023
@zqian
Copy link
Member

zqian commented May 20, 2024

@jonespm needs to re-eval

@zqian zqian assigned jonespm and unassigned jxiao21 and jaydonkrooss May 20, 2024
jonespm added a commit to jonespm/remote-office-hours-queue that referenced this issue Jan 14, 2025
@jonespm
Draft - WIP Changing form validation, evaluating use of *
baa6b1b 
Forxes tl-its-umich-edu#437
@jonespm jonespm linked a pull request Jan 14, 2025 that will close this issue
Draft
@jonespm jonespm moved this from To Do to In Progress in ROHQ 2025.01.01 Jan 14, 2025
@zqian zqian removed this from ROHQ 2025.01.01 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonespm jonespm

Labels
accessibility Involves changes intended to improve accessibility Effort: 8 Effort estimated at full day front end Involves changes to the front end (React) application and/or UI
Projects
ROHQ 2025.02.01
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft - WIP Changing form validation, evaluating use of * jonespm/remote-office-hours-queue
5 participants
@jonespm @zqian @ssciolla @jxiao21 @jaydonkrooss