Fix four UI issues (#434) #435
Conversation
ssciolla
added
🦟 bug
|
I am review now |
| allowedBackends={new Set(props.queue.allowed_backends)} | ||
| onChange={props.onChangeBackend} | ||
| selectedBackend={props.selectedBackend}/> | ||
| <Row> |
There was a problem hiding this comment.
Do you think the col-lg on line 372 might also be an issue and need to be updated?
There was a problem hiding this comment.
It's not an issue per se, but it's an instance of the direct Bootstrap class usage I've tried to move away from. Actually, this column turned out to be not needed, since it's not part of a larger grid structure (other Rows or Cols). Since this was the last instance of direct Bootstrap class usage in the module, I went ahead and removed it and used an Alert component there. It does have one side effect of setting role="alert", which makes it pretty noisy for screenreaders, but we're using Alert for other usages on the page. I could see setting role={undefined} for the SMS and management alerts, but they are conditional as well. Going to stick with the out-of-the-box Alert for now. 27c1109
This PR aims to resolve #434. See issue for details on the regressions or problems this resolves.