Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug perf manual #18
Debug perf manual #18
Changes from 8 commits
8d9dfa3
783ae38
d8eb403
50a5dea
7357c68
aa01651
a89b321
8be983a
5c74a15
834792b
897acdd
2655831
c7a4623
557aad1
fbc2c47
aeafefe
4cdccf0
00f7b3a
ed030fa
8f82b85
a1ec82b
f093ae8
22bffa8
77b5503
766eaa7
9affa8d
cef3415
7225e3b
260d6a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence reads incomplete to me. Are there words missing, "and sections of the runtime"?
Nit: The usual sequence surrounding "e.g" is
, e.g.,
https://www.merriam-webster.com/dictionary/e.g. (note: two commas and two periods)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious I've always known "e.g." to be used like
sections of the runtime written in C, e.g. Garbage Collector
without the trailing comma. That usage seems to be common to the existing manual pages, but I'm no National Grammar Rodeo Champion. ;-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick
grep "e\.g" *.etex
inmanual/src/cmds
reveals a different convention (mostly in parens, if not then with an initial comma but omitting the second comma) from the Merriam Webster one. Feel free to ignore this part then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do use the Oxford Comma in our style guide and also the comma after e.g. or i.e.
I'm totally obsessed with this stuff, so I'm sure to edit things that come across my desk to adhere to our style guide, but I certainly don't expect anyone else to remember all those details! I'll take care of those things. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @christinerose ! While we do want to use the style guide when writing our own documentation, blog posts and comms, in this case we are aiming at changes to an existing body of text. It's important that we retain uniformity, rather than impose our style guide. Let's ensure we do so!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's the MSVC exception. I don't know if it is worth a footnote/mention?
According to ocaml#11430 packed modules uses the
<SUB_MODULE_NAME>
convention, which may or may not be worth a footnote/mention?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth including a mention of MSVC 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I'm not following the last sentence. Can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent is you could strip an OCaml binary and still be able to debug it if you compile with frame pointers. You would only get stack frames with a call stack plus assembly code stepping and mangled names for setting breakpoints.
Having a stripped binary might be useful if you want the smallest executable possible for say MirageOS or performance. I haven't thoroughly tested this scenario but I wanted to include the option for completeness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first sentence seems to serve two purposes, collapsed into one. Suggestion: split it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a bit of explanation:
$rax
value
castingp
forprint
caml:14
- shouldn't this be 20? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps worth mentioning what this last examination provides (and how it works)?
Without being a
gdb
expert, I expected the value cast and @2 to print the value at offset 2, i.e., the second field as the comment suggests. The result looks more like a full record though? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last sentence probably earns a bit of elaboration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should both these be in monospace, or are you referring to Fibonacci rather than the
fib
command?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to print both the tagged representation - and the OCaml int value 20.
Why this difference across lldb and gdb? 🤔