Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

δ #150

Merged
merged 30 commits into from
Jan 13, 2023
Merged

δ #150

merged 30 commits into from
Jan 13, 2023

Conversation

uakci
Copy link
Contributor

@uakci uakci commented Jan 10, 2023

This is me setting down all the words that are new in δ that I could find going through the refgram definition-by-definition and example-by-example. I may have missed some things, and may not have cared to remove some older definitions (feel free to check my work and push patches to this branch).

Note: I've changed the glossing abbreviations for the existential tenses as well as jeha aımu béı. I think they make more sense that way (compositionally). @solpahi let me know if this is good to keep.

@uakci uakci requested review from lynn, robintown and solpahi January 10, 2023 13:34
@uakci
Copy link
Contributor Author

uakci commented Jan 10, 2023

Also: I haven't really tweaked the normalization script for δ, so entries starting with ꝡ may appear out of order. I don't want to fix this here since I don't want to invest resources in that legacy script.

Copy link
Contributor

@solpahi solpahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outstanding work, thank you!

dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
@uakci uakci requested a review from lynn January 10, 2023 17:02
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow uhhhhhhhh I got a bit carried away.. here's my review I guess!

dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Show resolved Hide resolved
dictionary.json Show resolved Hide resolved
dictionary.json Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Show resolved Hide resolved
This was referenced Jan 10, 2023
@uakci
Copy link
Contributor Author

uakci commented Jan 10, 2023

Phew, well, that was a long one. Thanks for the comprehensive reviews, @robintown! ^w^

Because of the Large and possibly bearing changes I'm going to rerequest review from @solpahi.

uakci and others added 3 commits January 10, 2023 23:49
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting through my notes and organizing the changes so nicely!

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@uakci uakci merged commit edf5c02 into master Jan 13, 2023
@uakci uakci deleted the δ branch January 13, 2023 19:19
@uakci uakci temporarily deployed to github-pages January 13, 2023 19:19 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants